fix(pulsar sink): Add new EncodingConfig #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Cameron <cameron.evan@gmail.com>
Signed-off-by: Evan Cameron <cameron.evan@gmail.com>
Signed-off-by: Evan Cameron <cameron.evan@gmail.com>
leshow
force-pushed
the
add_encoding_config
branch
from
5fc75d6
to
b802dec
Compare
fanatid
approved these changes
Jun 4, 2020
bruceg
added
sink: pulsar
Hoverbear
approved these changes
Jun 5, 2020
|
Thanks so much @leshow ! |
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
* Add encoding config to pulsar Signed-off-by: Evan Cameron <cameron.evan@gmail.com> * Fix encode_event Signed-off-by: Evan Cameron <cameron.evan@gmail.com> * fix tests Signed-off-by: Evan Cameron <cameron.evan@gmail.com> * fix pulsar test Signed-off-by: Evan Cameron <cameron.evan@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2648
Adds the new
EncodingConfigto the pulsar sink. I believe this is all that's required to get everything going again. It passes all the tests on my machine.