Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(elasticsearch sink): Show client errors as warning logs #2825

Merged
merged 1 commit into from
Jun 19, 2020
Merged

enhancement(elasticsearch sink): Show client errors as warning logs #2825

merged 1 commit into from
Jun 19, 2020

Conversation

tyrken
Copy link
Contributor

@tyrken tyrken commented Jun 15, 2020

While the existing code says errors are occurring, they don't help at all as to what the error actually is. This is very frustrating.

My rust-beginner code might be a bit rough/non-idiomatic - please butcher it as you wish, but include something as it was very useful tracking down Vector issues like #2814 and #2815

@binarylogic binarylogic requested a review from bruceg June 15, 2020 21:38
@bruceg bruceg added sink: elasticsearch Anything `elasticsearch` sink related type: enhancement A value-adding code change that enhances its existing functionality. labels Jun 15, 2020
bruceg
bruceg reviewed Jun 15, 2020
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please make sure to run make fmt (or simply cargo fmt) and consider the change I have suggested below.

src/sinks/elasticsearch.rs Outdated Show resolved Hide resolved
@tyrken tyrken changed the base branch from v0.9 to master June 17, 2020 18:04
@fanatid
Copy link
Contributor

fanatid commented Jun 17, 2020 •
edited
Loading

Thank you for changes, can you change base branch to master?

edit: need rebase :(

@tyrken
Display ES reject reasons
8815740 
Signed-off-by: Tristan Keen <tristan.keen@gmail.com>
@bruceg bruceg merged commit 5e00483 into vectordotdev:master Jun 19, 2020
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@tyrken
enhancement(elasticsearch sink): Show client errors as warning logs (v…
80df75d 
…ectordotdev#2825)

Signed-off-by: Tristan Keen <tristan.keen@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

@fanatid fanatid fanatid approved these changes

Assignees

@bruceg bruceg

Labels
sink: elasticsearch Anything `elasticsearch` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyrken @fanatid @bruceg