enhancement(internal_metrics source): instrument "stdin" source #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
jean/internalevents-stdin
branch
from
70d2d07
to
769b619
Compare
bruceg
added
source: stdin
bruceg
approved these changes
Jul 24, 2020
bruceg
changed the title
fanatid
reviewed
Jul 29, 2020
|
|
||
| impl InternalEvent for StdinEventReceived { | ||
| fn emit_logs(&self) { | ||
| trace!(message = "received one event.", rate_limit_secs = 10); |
There was a problem hiding this comment.
Should we have rate_limit_secs for trace! log? Currently only stdin and file use it.
There was a problem hiding this comment.
Not for tracing, in my opinion.
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…ordotdev#3151) Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2007
closes #3207