-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document internal instrumentation rules #3247
Comments
Additional rule: visibility of |
Also, as @fanatid mentioned in a PM, there is the question of using |
We need to make an official decision on naming before accepting PR #3264. Most of our "error" events are named without an |
The only reason I prefer the standardization is because we plan to document all of our errors, what they mean, etc. So I assume this will make it easier to parse these out of the code, but I'm sure there is a better way to go about this. |
About #3264, |
I agree and prefer the non- |
With #2660 this isn't so important. |
Closing since this is covered by https://github.com/vectordotdev/vector/blob/master/docs/specs/instrumentation.md |
I think it's time we add instrumentation rules for Vector itself in the
CONTRIBUTING.md
file. We purposefully deferred this to see what kind of questions come up, but we're starting to fully instrument Vector and consistency will be important.socket
source #3204 (comment)The text was updated successfully, but these errors were encountered: