chore: update tokio in tls #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanatid
added
type: tech debt
47 tasks
|
I'm not sure that we need these cyclical dependencies in features: sources-http = ["warp", "sources-tls"]
sources-logplex = ["warp", "sources-tls"]
sources-socket = ["bytesize", "listenfd", "tokio/uds", "tokio-util/udp", "sources-tls"]
sources-splunk_hec = ["bytesize", "warp", "sources-tls"]
sources-tls = ["sources-http", "sources-logplex", "sources-socket", "sources-splunk_hec"]I think that Addressed in #3210 |
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
bruceg
reviewed
Jul 24, 2020
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
fanatid
commented
Jul 27, 2020
fanatid
commented
Jul 27, 2020
|
TcpSink do not work properly now on shutdown :( need learn how compat works for fixing code =\ |
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
| .incoming() | ||
| .take(2) | ||
| .for_each(|connection| { | ||
| let mut close_rx = close_rx.take(); |
There was a problem hiding this comment.
Why did this need to become an option?
There was a problem hiding this comment.
tokio::sync::oneshot::Receiver not Copy and not Clone and can be used only once, but we have two connections, so I need say for a second that I do not have Receiver to it.
src/sinks/util/tcp.rs
Outdated
Comment on lines
96
to
102
| // enum TcpSinkState2 { | ||
| // Disconnected, | ||
| // ResolvingDns(BoxFuture<'static, Result<crate::dns::LookupIp, crate::dns::DnsError>>), | ||
| // Connecting(BoxFuture<'static, Result<MaybeTlsStream<TcpStream>, TlsError>>), | ||
| // Connected(FramedWrite<MaybeTlsStream<TcpStream>, BytesCodec>), | ||
| // Backoff(BoxFuture<'static, ()>), | ||
| // } |
There was a problem hiding this comment.
We should clean up all the commented out code before merging.
There was a problem hiding this comment.
Yeah, I understand that this code not related anyhow with current TcpSink, but can be very useful in future for saving time of anybody who will work on migrating to new Sink trait. If you insist to delete this, can I at least add a link to relevant code in this PR with a comment about new Sink trait impl?
binarylogic
modified the milestones:
2020.07.20 - The Great Orientation,
2020.08.03 - Observability Bonanza
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
fanatid
added a commit
to fanatid/vector
that referenced
this pull request
Aug 4, 2020
This reverts commit 9b05bdc.
fanatid
added a commit
that referenced
this pull request
Aug 4, 2020
This reverts commit 9b05bdc. Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
fanatid
added a commit
that referenced
this pull request
Aug 4, 2020
fanatid
added a commit
that referenced
this pull request
Aug 13, 2020
* chore: update tokio in tls Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
* chore: update tokio in tls Signed-off-by: Kirill Fomichev <fanatid@ya.ru> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
) This reverts commit 9b05bdc. Signed-off-by: Kirill Fomichev <fanatid@ya.ru> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #2945
Tokio update in
src/tls. Still need figure out lifetime problem for warp, see seanmonstar/warp#675 (currently works with patchedwarp: https://github.com/timberio/warp/tree/serve-incoming-lifetime)