Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(file source): correct an error with line aggregation in continue_through and halt_before #3262

Merged
merged 10 commits into from Jul 31, 2020
Merged

fix(file source): correct an error with line aggregation in continue_through and halt_before #3262

merged 10 commits into from Jul 31, 2020

Commits on Jul 30, 2020

  1. Hint which data is where 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    b4641b5 View commit details
    Browse the repository at this point in the history

  2. Add real life test case 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    d4021f4 View commit details
    Browse the repository at this point in the history

  3. Fix the issue with emitting multiple lines 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    2c9baa6 View commit details
    Browse the repository at this point in the history

  4. Rename real_life_use_case_1 into two_lines_emit_with_continue_through 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    459713f View commit details
    Browse the repository at this point in the history

  5. Adjust the samples at two_lines_emit_with_continue_through for better… 

    … formatting

Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    1d4756e View commit details
    Browse the repository at this point in the history

  6. Add a two_lines_emit_with_halt_before test 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    825c97f View commit details
    Browse the repository at this point in the history

  7. Fix an issue with emitting two messages at HaltBefore mode 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    3526887 View commit details
    Browse the repository at this point in the history

  8. Add a comment on debug_assert 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    61ebd38 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Use pretty_assertions 

    Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    83b8e9f View commit details
    Browse the repository at this point in the history

  2. Fix another set of bugs and corrected two_lines_emit_with_halt_before… 

    … test

- two_lines_emit_with_halt_before had hard to grasp example, which
  resulted in incorrect semantics, and effective a *wrong test*; the
  test samples were rewritten to ensure
- added more sample for the stashing logic tests, and hinted which test
  lines are going to be stashed for easier correspondence of the test logic
  with the code

Signed-off-by: MOZGIII <mike-n@narod.ru>
    @MOZGIII
    MOZGIII committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    22386ec View commit details
    Browse the repository at this point in the history