New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file source): correct an error with line aggregation in continue_through
and halt_before
#3262
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b4641b5
Hint which data is where
MOZGIII d4021f4
Add real life test case
MOZGIII 2c9baa6
Fix the issue with emitting multiple lines
MOZGIII 459713f
Rename real_life_use_case_1 into two_lines_emit_with_continue_through
MOZGIII 1d4756e
Adjust the samples at two_lines_emit_with_continue_through for better…
MOZGIII 825c97f
Add a two_lines_emit_with_halt_before test
MOZGIII 3526887
Fix an issue with emitting two messages at HaltBefore mode
MOZGIII 61ebd38
Add a comment on debug_assert
MOZGIII 83b8e9f
Use pretty_assertions
MOZGIII 22386ec
Fix another set of bugs and corrected two_lines_emit_with_halt_before…
MOZGIII File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I'll have to remember that one for my own tests. Too badd we can't turn that on across all the sources at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed it being used at the
file/mod.rs
and it looked really good.Can't we import it at
/lib.rs
with an old#[macro_use] extern crate pretty_assertions;
?