Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(prometheus source): Update instrumentation #3317

Merged
merged 2 commits into from
Aug 4, 2020
Merged

enhancement(prometheus source): Update instrumentation #3317

merged 2 commits into from
Aug 4, 2020

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Aug 2, 2020 •
edited
Loading

Closes #3203

Open questions

@ktff
Add instrumentation
fa3513c 
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
@ktff ktff added type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector source: prometheus labels Aug 2, 2020
@ktff ktff requested a review from lukesteensen August 2, 2020 21:08
@ktff ktff self-assigned this Aug 2, 2020
lukesteensen
lukesteensen approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter can be derived from the timer, but I'm not sure if that provides the simplest UX since naming will be less obvious. I think we can duplicate for now and decide later if we want to combine.

@binarylogic
Copy link
Contributor

Thanks @ktff. Can we rename the metric to request_duration_seconds (or whatever unit it is)? Taking a page from Promtheus' naming recommendations.

@binarylogic binarylogic mentioned this pull request Aug 3, 2020
Closed
@ktff
Rename to request_duration_nanoseconds
8a9c2d7 
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
@ktff ktff merged commit 67adfd6 into master Aug 4, 2020
@ktff ktff deleted the ktff/prometheus_source_inst branch August 4, 2020 09:07
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@ktff
enhancement(prometheus source): Update instrumentation (vectordotdev#…
9fc065e 
…3317)

* Add instrumentation

Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>

* Rename to request_duration_nanoseconds

Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesteensen lukesteensen lukesteensen approved these changes

Assignees

@ktff ktff

Labels
domain: observability Anything related to monitoring/observing Vector type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define events for the prometheus source
3 participants
@ktff @binarylogic @lukesteensen