Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(kubernetes_logs source): Add reference docs #3555

Merged
merged 4 commits into from
Sep 14, 2020
Merged

docs(kubernetes_logs source): Add reference docs #3555

merged 4 commits into from
Sep 14, 2020

Conversation

binarylogic
Copy link
Contributor

Supersedes #3280 since we no longer host the website in this repo.

@binarylogic binarylogic mentioned this pull request Aug 25, 2020
Closed
jamtur01
jamtur01 suggested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor fixes needed. The field name to annotate Pod name as and related sentences. It's not clear what these are trying to say.

.meta/sources/kubernetes_logs.toml.erb Outdated Show resolved Hide resolved
.meta/sources/kubernetes_logs.toml.erb Outdated Show resolved Hide resolved
.meta/sources/kubernetes_logs.toml.erb Outdated Show resolved Hide resolved
@binarylogic
Copy link
Contributor Author

@MOZGIII would you mind making the changes above? (copied from #3280)

Also, I'm realizing we'll need an entry into .meta/installation/platforms.toml as well. That'll drive the installation pages.

Thanks.

@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 27, 2020

@MOZGIII would you mind making the changes above? (copied from #3280)

Sure.

Also, I'm realizing we'll need an entry into .meta/installation/platforms.toml as well. That'll drive the installation pages.

Looks like we'll need to add a logo at the vector-website. I'll create a relevant PR.

@MOZGIII MOZGIII force-pushed the kubernetes_logs-source-docs branch from 4a9835f to 5108ace Compare August 27, 2020 18:14
@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 28, 2020

I'm having trouble checking the results of 5108ace - does it look right?

@MOZGIII MOZGIII requested a review from jamtur01 August 28, 2020 13:12
@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 28, 2020

Addressed the wording and typos

binarylogic and others added 4 commits August 28, 2020 16:13
@binarylogic @MOZGIII
docs(kubernetes_logs source): Add reference docs
74c06e5 
Signed-off-by: binarylogic <bjohnson@binarylogic.com>
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII
Fix typo
5e8927d 
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII
Add Kubernetes at .meta/installation/platforms.toml
6be5cb8 
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII
Adjust the annotator config docs
e8eacc2 
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII MOZGIII force-pushed the kubernetes_logs-source-docs branch from 86bc86f to e8eacc2 Compare August 28, 2020 13:13
@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 28, 2020

Rebased the code to apply DCO signoff

jamtur01
jamtur01 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MOZGIII
MOZGIII approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binarylogic I think we can merge it!

@jamtur01 jamtur01 merged commit b85927c into master Sep 14, 2020
@jamtur01 jamtur01 deleted the kubernetes_logs-source-docs branch September 14, 2020 22:21
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@binarylogic @MOZGIII
docs(kubernetes_logs source): Add reference docs (vectordotdev#3555)
4384f5f 
Co-authored-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamtur01 jamtur01 jamtur01 approved these changes

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees

@MOZGIII MOZGIII

Labels
None yet
Projects
None yet
Milestone
2020-09-14 - The Grid
Development

Successfully merging this pull request may close these issues.
3 participants
@binarylogic @MOZGIII @jamtur01