fix(humio_logs sink): Set host key correctly #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sink was previously not setting the `host` key of the Splunk HEC format (https://docs.humio.com/integrations/ingest-logs-with-a-data-shipper/hec/) as the `host_key` field on the `SinkHecConfig` was defaulting `host_key` to `''`. I opted to expose the `host_key` as a config option on the Humio sink to parallel its existence on the Splunk HEC sink. Fixes #4228 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jamtur01
reviewed
Sep 30, 2020
.meta/sinks/humio_logs.toml.erb
Outdated
| required = false | ||
| description = """\ | ||
| The name of the log field to be used as the hostname sent to Humio. This \ | ||
| overrides the \ [global `host_key` \ |
There was a problem hiding this comment.
Extra \ here perhaps? I see the check-meta failing.
There was a problem hiding this comment.
Oops, thanks! I line wrapped and miss that \.
lukesteensen
approved these changes
Oct 2, 2020
|
Failing tests are #4196 and an issue pulling from dockerhub that I think is not worth redoing given the scope of this change |
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
* fix(humio_logs sink): Set host key correctly This sink was previously not setting the `host` key of the Splunk HEC format (https://docs.humio.com/integrations/ingest-logs-with-a-data-shipper/hec/) as the `host_key` field on the `SinkHecConfig` was defaulting `host_key` to `''`. I opted to expose the `host_key` as a config option on the Humio sink to parallel its existence on the Splunk HEC sink. Fixes vectordotdev#4228 Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sink was previously not setting the
hostkey of the Splunk HECformat
(https://docs.humio.com/integrations/ingest-logs-with-a-data-shipper/hec/)
as the
host_keyfield on theSinkHecConfigwas defaultinghost_keyto
''.I opted to expose the
host_keyas a config option on the Humio sink toparallel its existence on the Splunk HEC sink.
Fixes #4228
Signed-off-by: Jesse Szwedko jesse@szwedko.me