Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(remap): non-boolean if conditional compile-time error #5835

Merged
merged 1 commit into from
Jan 5, 2021
Merged

enhancement(remap): non-boolean if conditional compile-time error #5835

merged 1 commit into from
Jan 5, 2021

Conversation

JeanMertz
Copy link
Contributor

Uplifts non-boolean if-statement conditional from runtime to compile-time error.

closes #5116.

@JeanMertz
enhancement(remap): non-boolean if conditional compile-time error
4933eaf 
Signed-off-by: Jean Mertz <git@jeanmertz.com>
@JeanMertz JeanMertz added type: enhancement A value-adding code change that enhances its existing functionality. domain: vrl Anything related to the Vector Remap Language labels Jan 4, 2021
@JeanMertz JeanMertz added this to the 2021-01-04 Xenomass Well milestone Jan 4, 2021
@JeanMertz JeanMertz self-assigned this Jan 4, 2021
@JeanMertz JeanMertz removed the request for review from binarylogic January 4, 2021 13:56
jszwedko
jszwedko approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

StephenWakely
StephenWakely approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@JeanMertz JeanMertz merged commit 9485997 into master Jan 5, 2021
@JeanMertz JeanMertz deleted the jean/if-condition-bool branch January 5, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenWakely StephenWakely StephenWakely approved these changes

@jszwedko jszwedko jszwedko approved these changes

Assignees

@JeanMertz JeanMertz

Labels
domain: vrl Anything related to the Vector Remap Language type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
2021-01-04 Xenomass Well
Development

Successfully merging this pull request may close these issues.

Require Remap if-statement boolean conditionals at compile-time
3 participants
@JeanMertz @StephenWakely @jszwedko