fix(config): disallow non-unique component names #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6268 Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
lukesteensen
requested review from
a team and
bruceg
and removed request for
a team
Neither of these seems to be related to the change. |
bruceg
reviewed
Jan 28, 2021
src/config/validation.rs
Outdated
Comment on lines
15
to
16
| // Check for non-unique names across sources, sinks, and transforms | ||
| let mut name_counts = HashMap::<&str, usize>::new(); |
There was a problem hiding this comment.
Would it be worth trying to tell the user which kind of component was colliding? Then we'd collect into a HashMap::<&str, Vec<ComponentKind>>.
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
bruceg
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6268