enhancement(helm platform): Kubernetes recommanded labels and additional labels

[nlamirault]

Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com

[spencergilbert]

Left a couple of thoughts

[spencergilbert]

Thanks for adding this @nlamirault - I've left a couple more notes and requests

[spencergilbert]

Sorry @nlamirault - I realize I wasn't super clear. For the global.commonLabels we should put it here, like the existing commonEnvKV.

This is an example of us determining which value (global vs "local") but I can see a use for defining at both levels at the same time, so I think we can just do an if ...toYaml global.commonLabels end followed by the same but for "local."

Does that seem reasonable to you?

[nlamirault]

Sorry @nlamirault - I realize I wasn't super clear. For the global.commonLabels we should put it here, like the existing commonEnvKV.

This is an example of us determining which value (global vs "local") but I can see a use for defining at both levels at the same time, so I think we can just do an if ...toYaml global.commonLabels end followed by the same but for "local."

Does that seem reasonable to you?

like ?

{{- if .Values.global }}
{{- if .Values.global.vector }}
{{- if .Values.global.vector.commonLabels }}
{{ toYaml .Values.global.vector.commonLabels }}
{{- end }}
{{- end }}
{{- end }}

{{- if .Values.commonLabels }}
{{ toYaml .Values.commonLabels }}
{{- end }}

and :

global:
  vector:
    # Additional labels to add to all resources
    commonLabels: #{}
      app: vector

commonLabels: #{}
  app.kubernetes.io/component: agent

commonLabels: #{}
  app.kubernetes.io/component: aggregator

[spencergilbert]

Yep - that looks like it should work 👍

[spencergilbert]

Thanks - @jszwedko do you have any more thoughts here? We will be adding some more labels by default, that doesn't really bother me but wasn't sure if you had an opinion

[spencergilbert]

Thanks again for the updates, left some suggestions to keep the existing behavior by default.

[spencergilbert]

Thanks so much @nlamirault, really appreciate the PR 😃 mind re-generating the resource files and I'll merge once the check is green

[spencergilbert]

Thanks!