enhancement(cli)!: Write logs to stderr #9166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than stdout. This change was made because: * It makes it easier to redirect `console` sink output which defaults to stdout * stderr is typically unbuffered so diagnostic messages are less likely to be lost * Users typically expect diagnostic output on stderr. stdout is for application output. Closes: #1740 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: b5485f2 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6143c5e60caf8c0008aa7f67 😎 Browse the preview: https://deploy-preview-9166--vector-project.netlify.app |
spencergilbert
approved these changes
Sep 15, 2021
binarylogic
approved these changes
Sep 15, 2021
|
What do you think about adding information about the stream usage on this page? |
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than stdout. This change was made because:
consolesink output which defaults tostdout
to be lost
application output.
Closes: #1740
Signed-off-by: Jesse Szwedko jesse@szwedko.me