enhancement(observability, sinks): Emit events for sent events in all HttpSink sinks #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
bruceg
added
sink: http
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: dbefe49 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/614a6315a3dd280007ee47ea 😎 Browse the preview: https://deploy-preview-9275--vector-project.netlify.app |
spencergilbert
approved these changes
Sep 21, 2021
jszwedko
reviewed
Sep 21, 2021
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
…lity Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
blt
approved these changes
Sep 21, 2021
jszwedko
approved these changes
Sep 21, 2021
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being pretty simple, as the events flow through only two paths for all these sinks.
After going in to add the metric documentation into each sink, I decided to move it into the common sink documentation, since it will eventually be added to all sinks, and the
events_out_totalis already documented there. If this is not appropriate, I can move it back to each individual sink.Closes #9225