chore(splunk_hec sink): Rewrite Splunk HEC metrics sink into the new style #9813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: ac5375a 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6179b57ef999db000723de02 |
Signed-off-by: 001wwang <will.wang@datadoghq.com>
|
@001wwang adding a soak that removes transforms would be interesting, yeah. |
blt
approved these changes
Oct 27, 2021
Comment on lines
+20
to
+25
| [transforms.remap] | ||
| type = "remap" | ||
| inputs = ["syslog"] | ||
| source = """ | ||
| . = parse_syslog!(.message) | ||
| """ |
There was a problem hiding this comment.
You could avoid this step entirely if you used, say, datadog_agent ingress.
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Signed-off-by: 001wwang <will.wang@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9735
This PR rewrites the Splunk HEC metrics sink into the new style and consolidates some common functionality between the
logsandmetricssink. Namely, the two share theirServicerelated code (HecRequest,HecResponse,HecRetryLogic,HecService, etc.) as they communicate with Splunk in the same way. I plan to add some more integration tests (sending multiple events), but the overall approach is ready for review.Soak test results for
syslog -> remap -> log_to_metric -> splunk_hec_metrics:(wow, what are the chances that the
VALUE_minis a commit SHA)The results are similar/slightly improved. The similarity of this soak with the
syslog_log2metric_humio_metricssoak and the similar throughput results again lead me to believe the transforms are the limitation here. I may add a new soak that avoids transforms.