Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling pdf-view-auto-slice-minor-mode #44

Closed
dschaehi opened this issue Sep 24, 2021 · 0 comments
Closed

Toggling pdf-view-auto-slice-minor-mode #44

dschaehi opened this issue Sep 24, 2021 · 0 comments
Labels
needs investigation Something isn't working, need to understand what the actual problem is

Comments

@dschaehi
Copy link

Toggling pdf-view-auto-slice-minor-mode does not reset the slice. I'd like to suggest to add (pdf-view-reset-slice) to the following part of pdf-view-auto-slice-minor-mode, i.e., replacing

pdf-tools/lisp/pdf-view.el

Lines 879 to 880 in 5f77dae

(remove-hook 'pdf-view-change-page-hook
'pdf-view-set-slice-from-bounding-box t))))

with

(progn
        (remove-hook 'pdf-view-change-page-hook
                     'pdf-view-set-slice-from-bounding-box t)
        (pdf-view-reset-slice))
@vedang vedang added pending review Maintainer needs to review the changes needs investigation Something isn't working, need to understand what the actual problem is and removed pending review Maintainer needs to review the changes labels Dec 31, 2021
@vedang vedang closed this as completed in b0f01a9 Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation Something isn't working, need to understand what the actual problem is
Projects
None yet
Development

No branches or pull requests

2 participants