Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in hw 75 phase filter state setter #56

Closed
Teslafly opened this issue Apr 23, 2018 · 1 comment
Closed

bug in hw 75 phase filter state setter #56

Teslafly opened this issue Apr 23, 2018 · 1 comment

Comments

@Teslafly
Copy link
Contributor

I see your hw_75 config file and am excited.
Finally had to ditch the drv for some higher voltage gate drivers I see.

In your phase filter setter (lines 42-42 in hw_75_300.h)
#define PHASE_FILTER_ON() palSetPad(GPIOC, 11)
#define PHASE_FILTER_OFF() palClearPad(GPIOB, 11)
I believe one of them is using the wrong port.

On this note, a cursourly look through and it appears HW_HAS_PHASE_FILTERS is not used. As I am currently 90% of the way through designing my own similar hw derivative (100v max, 250a phase) and now looking at adjusting code / defines. Just curious, what is the hw implementation of your filters? Fets tying capacitors to gnd?

@vedderb
Copy link
Owner

vedderb commented Feb 19, 2019

This is now fixed, but the phase filter needs some work to be implemented. It is still unused.

@vedderb vedderb closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants