Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataloss when reopen and overwriting an existing .vescpkg file #335

Closed
Tomblarom opened this issue Nov 8, 2023 · 5 comments
Closed

Dataloss when reopen and overwriting an existing .vescpkg file #335

Tomblarom opened this issue Nov 8, 2023 · 5 comments

Comments

@Tomblarom
Copy link

I just finished modifying an existing VESC package and it discarded all the made changes!
Under "Output" --> Choose file.. --> Selected existing .vescpkg --> confirmed override --> Save Package.

Its reproduceable. I expected the package to be overwritten and saved, instead of discarding my changes.. This is frustrating..

@vedderb
Copy link
Owner

vedderb commented Nov 13, 2023

It should save when selecting the file in the latest beta. Before it would just update the path box, but not save.

@Tomblarom
Copy link
Author

Tomblarom commented Nov 14, 2023

Yes it saves now, but unfortunately it's not as intended. 😅 I was rather expecting the folder-icon to select an output path. Instead it loads the test.vescpkg and overwrites the contents in my newly written description field.

image

It should only do that, when I click the load/refresh-button. :)

@vedderb
Copy link
Owner

vedderb commented Nov 14, 2023

I realized that it should not save the file actually, I removed that change again. The intention is that you can open a package you have been working on and continue working on it. So the first step would be to select the file you will be working with and then work on it and save the changes as you go. I will put some effort into that editor soon to make it a bit easier to use and understand.

@vedderb
Copy link
Owner

vedderb commented Nov 14, 2023

Hope this makes it more clear for now: 820f5e9

@Tomblarom
Copy link
Author

Tomblarom commented Nov 15, 2023

Perfect. This is more what a user would expect, when an overwrite is about to happen!
image

Beyond that wasn't finding any issues. Loading/saving works fine. I might give some feedback over here: #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants