Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structs #87

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Structs #87

wants to merge 23 commits into from

Conversation

encukou
Copy link
Contributor

@encukou encukou commented Oct 14, 2012

  • Generation 5 PKM support
  • Most SaveFilePokemon's properties are now mutable, blob and the dex entities (species, ability, ...) loaded on demand
  • Export/import to/from a human-grokkable dict (sadly, not yet very human modifiable: for loading it ignores names and uses internal IDs)
  • pokedex pkm subcommand to show off the new functionality (raw/base64 plain/crypted PKM ↔ YAML/JSON/Python literal)
  • Internal IDs in tables.Nature
  • Tests, and an utility to run round-trip testing against a collection of PKM files

Could be better, but it's usable. Please comment.

- Update for Generation 5. This means SaveFilePokemon becomes an abstract
  base, with SaveFilePokemonGen4 and SaveFilePokemonGen5 subclasses.
  The pokemon_struct is changed to a structure factory.
  Diff best viewed with the ignore whitespace setting.
- Allow creating a SaveFilePokemon with a zeroed-out blob (to be filled
  in later). Several fields are zeroed out in gen 5 so this helps the
  above.
And if exp is just enough to reach the given level, leave exp out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant