You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Trellis function has the argument for the generator polynomial marked as
g_matrix : 2D ndarray of ints (octal representation)
i.e. base 8 polynomial. This is extremely misleading as the actual argument expected is that of a standard base 10 integer (the function calls the utility function dec2bin). This doesn't cause problems in the examples as the polynomials used there are less than 8, but upon implementing anything with longer memory the output was all wrong and caused a big headache.
Suggestion: amend the documentation to denote g_matrix as base 10.
The text was updated successfully, but these errors were encountered:
BastienTr
added a commit
to BastienTr/CommPy
that referenced
this issue
Jun 27, 2019
The Trellis function has the argument for the generator polynomial marked as
g_matrix : 2D ndarray of ints (octal representation)
i.e. base 8 polynomial. This is extremely misleading as the actual argument expected is that of a standard base 10 integer (the function calls the utility function dec2bin). This doesn't cause problems in the examples as the polynomials used there are less than 8, but upon implementing anything with longer memory the output was all wrong and caused a big headache.
Suggestion: amend the documentation to denote g_matrix as base 10.
The text was updated successfully, but these errors were encountered: