Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-rendering with className causes react-embed to lose styling #535

Open
agirton opened this issue Aug 12, 2022 · 0 comments
Open

Re-rendering with className causes react-embed to lose styling #535

agirton opened this issue Aug 12, 2022 · 0 comments

Comments

@agirton
Copy link

agirton commented Aug 12, 2022

Hello!

Noticed that due to the way react-embed applies the className to the parent dom node, if a component re-renders and it uses the className prop on ReactVega it causes the react-embed className to be dropped. You can see an example here in codesandbox if you add className="hi" the embed styling gets dropped. A work around for us is we can add a wrapper div and not apply a className to this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant