Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unknown type "undefined" when using generics without base type #1978

Merged
merged 3 commits into from
May 29, 2024

Conversation

arthurfiorette
Copy link
Collaborator

@arthurfiorette arthurfiorette commented May 29, 2024

closes #1977

πŸ“¦ Published PR as canary version: 2.2.1--canary.1978.156da78.0

✨ Test out this PR locally via:

npm install ts-json-schema-generator@2.2.1--canary.1978.156da78.0
# or 
yarn add ts-json-schema-generator@2.2.1--canary.1978.156da78.0

Version

Published prerelease version: v2.3.0-next.4

Changelog

πŸš€ Enhancement

πŸ› Bug Fix

πŸ”© Dependency Updates

Authors: 3

@arthurfiorette arthurfiorette self-assigned this May 29, 2024
@arthurfiorette arthurfiorette linked an issue May 29, 2024 that may be closed by this pull request
@arthurfiorette
Copy link
Collaborator Author

The problem is surely deeper than that, since its returning undefined to a type that should always be defined, but this is a temp fix until I have time to deeper investigate this issue.

src/NodeParser/ArrayNodeParser.ts Outdated Show resolved Hide resolved
@arthurfiorette arthurfiorette enabled auto-merge (squash) May 29, 2024 16:05
@arthurfiorette arthurfiorette merged commit f411396 into next May 29, 2024
3 checks passed
@arthurfiorette arthurfiorette deleted the 1977-error-unknown-type-undefined branch May 29, 2024 16:12
Copy link

github-actions bot commented Jun 5, 2024

πŸš€ PR was released in v2.3.0 πŸš€

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Unknown type "undefined"
2 participants