Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ts-expose-types temporarily #1968

Merged
merged 1 commit into from
May 25, 2024

Conversation

arthurfiorette
Copy link
Collaborator

@arthurfiorette arthurfiorette commented May 24, 2024

closes #1967

This PR removes ts-expose-internals until nonara/ts-expose-internals#14 has a solution.

Published at 2.3.0--canary.1968.a70651a.0

Version

Published prerelease version: v2.3.0-next.1

Changelog

🚀 Enhancement

Authors: 1

📦 Published PR as canary version: 2.3.0--canary.1968.c39cb48.0

✨ Test out this PR locally via:

npm install ts-json-schema-generator@2.3.0--canary.1968.c39cb48.0
# or 
yarn add ts-json-schema-generator@2.3.0--canary.1968.c39cb48.0

@arthurfiorette
Copy link
Collaborator Author

arthurfiorette commented May 24, 2024

Hey @sebbi08, could you try ts-json-schema-generator@2.3.0--canary.1968.a70651a.0 and see if it fixes your problem?

@arthurfiorette
Copy link
Collaborator Author

I think it's safe to merge this PR. All tests are passing and I just tested on my local machine and this really fixes it :)

@arthurfiorette arthurfiorette merged commit c39cb48 into next May 25, 2024
3 checks passed
@arthurfiorette arthurfiorette deleted the arthur/remove-ts-expose-types branch May 25, 2024 19:18
@domoritz
Copy link
Member

Please use semantic commit title for the PRs so that we can auto bump to the right versions.

@domoritz domoritz changed the title Remove ts-expose-types temporarily fix: remove ts-expose-types temporarily May 25, 2024
@arthurfiorette
Copy link
Collaborator Author

Sorry 😅

@domoritz
Copy link
Member

All good. I didn't tell you before approving the pull request.

Copy link

github-actions bot commented Jun 5, 2024

🚀 PR was released in v2.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dist types now require @types/ts-expose-internals
2 participants