Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --strictTuples option: disallows additional elements in tuples #29

Merged
merged 6 commits into from
Jun 8, 2018

Conversation

marcoqu
Copy link
Contributor

@marcoqu marcoqu commented Jun 8, 2018

With the --strictTuples option enabled, the generated schema does not allow for additional properties.

See issue #28

@domoritz domoritz self-requested a review June 8, 2018 16:38
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Looks great!

README.md Outdated

```
-e, --expose <all|none|export>
all: Create shared $ref definitions for all types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent and add . to the end of all of these.

@domoritz domoritz merged commit 7b8406e into vega:master Jun 8, 2018
@domoritz
Copy link
Member

domoritz commented Jun 8, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants