Open in editor breaks if data is not available

[domoritz]

Since URLs in Vega or Vega-Lite specs can be relative, the URLs may not be correct. We could either use the origin URL as the baseurl or send the data along when a spec is opened in the editor.

[timelyportfolio]

will take a look...

[timelyportfolio]

Seems like we could test the spec for data:url. If exists, test for relative. If relative, change spec to new URL(data:url, window.location.href).href and send new spec through post. I checked new URL() and it seems to work with absolute and relative url.

@domoritz, does this approach fit your expectation?

[domoritz]

We should avoid reading the spec. I suggest that we create our own vega loader that checks a relative URL and attaches the baseurl of the post sender if the relative URL returns a 404. This should be done in the editor (https://github.com/vega/editor).

Vega embed only needs to be changed to send the baseurl (I don't know whether post already does that, haven't checked).

[ydlamba]

I just checked that Vega embed is already sending the baseURL of sender in the post request. So, I think no change needed here.

[domoritz]

Sweet. I guess it's coming in via the POST message, right?

[domoritz]

Done in editor.