Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow setting width/height in repeated layers #8723

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: allow setting width/height in repeated layers #8723

merged 1 commit into from
Mar 6, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Feb 20, 2023 •
edited
Loading

Replaces #8676
Fixes #8523

@domoritz domoritz requested a review from kanitw February 20, 2023 05:29
@domoritz domoritz mentioned this pull request Feb 20, 2023
Closed
@domoritz domoritz requested a review from arvind March 2, 2023 20:03
arvind
arvind approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@arvind arvind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvind arvind merged commit 9e26410 into main Mar 6, 2023
@arvind arvind deleted the dom/repeat-size branch March 6, 2023 20:42
@mattijn mattijn mentioned this pull request Apr 20, 2023
Closed
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
fix: allow setting width/height in repeated layers (vega#8723)
065ffad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvind arvind arvind approved these changes

@kanitw kanitw Awaiting requested review from kanitw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeat operator with defined width and height does not accept layer
2 participants
@domoritz @arvind