Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make timeUnit band respect x2Offset #8956

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jun 20, 2023

Fix #8955

@kanitw kanitw requested review from fandu-db and domoritz June 20, 2023 17:40
@kanitw kanitw marked this pull request as ready for review June 20, 2023 17:40
@kanitw kanitw force-pushed the kw/8955-x2offset-time-bin branch from cdc5679 to 01d0197 Compare June 20, 2023 17:42
Copy link
Contributor

@fandu-db fandu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kanitw kanitw merged commit f8a0cfa into main Jun 20, 2023
@kanitw kanitw deleted the kw/8955-x2offset-time-bin branch June 20, 2023 18:46
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x2Offset not respected for timeUnit band
2 participants