Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9401): conditional opacity should respect default value #9402

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jul 31, 2024

PR Description

Conditional opacity should respect default value

Before:

image

config.point.opacity = 0.5 is ignored

After:

image

@kanitw kanitw requested a review from a team as a code owner July 31, 2024 22:00
Copy link

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cc9898
Status: ✅  Deploy successful!
Preview URL: https://ed1f28d9.vega-lite.pages.dev
Branch Preview URL: https://kw-9401-conditional-opacity.vega-lite.pages.dev

View logs

@kanitw kanitw merged commit b4c7e14 into main Jul 31, 2024
9 checks passed
@kanitw kanitw deleted the kw/9401-conditional-opacity branch July 31, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants