Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct projection precision's type to number (not string) #5191

Merged
merged 1 commit into from
Jul 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/vega-lite-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -8982,7 +8982,7 @@
},
"precision": {
"description": "Sets the threshold for the projection’s [adaptive resampling](http://bl.ocks.org/mbostock/3795544) to the specified value in pixels. This value corresponds to the [Douglas–Peucker distance](http://en.wikipedia.org/wiki/Ramer%E2%80%93Douglas%E2%80%93Peucker_algorithm). If precision is not specified, returns the projection’s current resampling precision which defaults to `√0.5 ≅ 0.70710…`.",
"type": "string"
"type": "number"
},
"radius": {
"type": "number"
Expand Down
2 changes: 1 addition & 1 deletion src/projection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export interface Projection {
/**
* Sets the threshold for the projection’s [adaptive resampling](http://bl.ocks.org/mbostock/3795544) to the specified value in pixels. This value corresponds to the [Douglas–Peucker distance](http://en.wikipedia.org/wiki/Ramer%E2%80%93Douglas%E2%80%93Peucker_algorithm). If precision is not specified, returns the projection’s current resampling precision which defaults to `√0.5 ≅ 0.70710…`.
*/
precision?: string;
precision?: number;
/*
* Sets whether or not the x-dimension is reflected (negated) in the output.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/vega.schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export interface VgProjection {
/*
* The desired precision of the projection.
*/
precision?: string;
precision?: number;
/*
* GeoJSON data to which the projection should attempt to automatically fit the translate and scale parameters..
*/
Expand Down