Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove humpfit (move to natto) #289

Closed
jarioksa opened this issue Aug 16, 2018 · 1 comment
Closed

Remove humpfit (move to natto) #289

jarioksa opened this issue Aug 16, 2018 · 1 comment

Comments

@jarioksa
Copy link
Contributor

I consider removing humpfit function from vegan. It is a fringe function for a very special analysis, and may also be tricky to use.

I started the project of removal by moving the function with its known history to the natto package here in the github (https://github.com/jarioksa/natto/). If I decide to go on with the transfer, I'll take the following steps:

  1. deprecate humpfit both in 2.6-0 and 2.5-3.
  2. defunct humpfit in 2.6-0 and remove its support functions.
  3. remove all remains of humpfit in 2.7-0.
jarioksa pushed a commit that referenced this issue Aug 23, 2018
document deprecation of humpfit
b1cad56 
Further comments and deprecation plan can be found in github
issue #289.

This commit closes the deprecation stage: next we move to
making humpfit defunct.
jarioksa pushed a commit that referenced this issue Aug 28, 2018
document deprecation of humpfit
31b55b4 
Further comments and deprecation plan can be found in github
issue #289.

This commit closes the deprecation stage: next we move to
making humpfit defunct.

(cherry picked from commit b1cad56)
jarioksa pushed a commit that referenced this issue Aug 29, 2018
remove trivial S3 methods of humpfit
fad03e1 
this still keeps the code of profile and predict for humpfit,
but these methods are not registered in the NAMESPACE.

This closes the second stage of github issue #289
@jarioksa
Copy link
Contributor Author

Done now. No objections communicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarioksa