Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: long block extension trigger is extending the auction by too long #11419

Closed
ze97286 opened this issue Jul 1, 2024 · 0 comments · Fixed by #11420
Closed

[Bug]: long block extension trigger is extending the auction by too long #11419

ze97286 opened this issue Jul 1, 2024 · 0 comments · Fixed by #11420
Assignees
Labels

Comments

@ze97286
Copy link
Contributor

ze97286 commented Jul 1, 2024

Problem encountered

Suppose we're in a monitoring auction and we see a long block, the expiry of the long block duration should be between now and the duration implied by the threshold rather than just extend the existing auction by the duration. E.g. suppose the monitoring auction should end at 10:00 and at 9:45 we get a long block, which implies 1 minute auction duration - the auction should not be extended at all. If the auction duration implied by the long block is 20 minutes, then the auction should be extended by 5 minutes, etc.

Observed behaviour

Extension of an auction due to long block does not work as expected.

Expected behaviour

Long block extension should be calculated with respect to the current time and only extend the auction if the current time + duration implied by the threshold is later than the current auction expiry.

Steps to reproduce

1. Submit `xyz` transaction
2. With this payload
3. Query `abc` API
4. Observe the error

Software version

develop

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant