New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad validation on proposal terms. #3304

Closed

jeremyletang opened this issue Apr 2, 2021 · 0 comments · Fixed by #3305

Assignees

Member

jeremyletang commented Apr 2, 2021

At the moment validation on proposal terms is done only on Markets and Netparams.

no validation is done on NewAsset
no error is returned when a term is not specificed or invalid.

This was raised from a proposal made on staging, with a term having a typo in the rest API, resulting in a nil term in the proto type.

jeremyletang self-assigned this

jeremyletang mentioned this issue

fix governance validation of proposal terms #3305

Merged

jeremyletang closed this as completed in #3305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment