Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated feature tests #3101

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Remove outdated feature tests #3101

merged 3 commits into from
Mar 9, 2021

Conversation

ValentinTrinque
Copy link
Contributor

Close #3097

@ValentinTrinque ValentinTrinque marked this pull request as draft March 5, 2021 15:39
@ValentinTrinque ValentinTrinque force-pushed the feature/3097-oudated-fetaure-tests branch from 45b43b1 to 6c14f65 Compare March 5, 2021 16:37
@ValentinTrinque ValentinTrinque self-assigned this Mar 9, 2021
@ValentinTrinque ValentinTrinque marked this pull request as ready for review March 9, 2021 09:08
@ValentinTrinque ValentinTrinque force-pushed the feature/3097-oudated-fetaure-tests branch from 7f0fc3c to da05a45 Compare March 9, 2021 12:23
@ValentinTrinque
Remove outdated feature tests
2b054ef
@ValentinTrinque
Add generic table wraper for gherkin
52a7471
@ValentinTrinque
Cleaner and uniform market declaration in feature tests
ccd764c 
We were using indexes to iterate through the table, which required to update all the indexes when adding or removing a column.

To ease the maintenance of suche table, we introduce a generic layer to get the column by name, with appropriate type conversion.

This makes us switch from the indexes to column name.

To makes things even clearer, we add a specific layer on top of the generic one and abstract away column names into accessors.

Doing so requires us to uniformize the column name across all tests, which is a good thing.
@ValentinTrinque ValentinTrinque force-pushed the feature/3097-oudated-fetaure-tests branch from da05a45 to ccd764c Compare March 9, 2021 12:34
@jeremyletang jeremyletang merged commit 9b5cc03 into develop Mar 9, 2021
@jeremyletang jeremyletang deleted the feature/3097-oudated-fetaure-tests branch March 9, 2021 12:44
@edd edd mentioned this pull request Mar 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees

@ValentinTrinque ValentinTrinque

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove outdated feature tests
2 participants
@ValentinTrinque @jeremyletang