Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated feature tests #3101

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Remove outdated feature tests #3101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b054ef
Remove outdated feature tests
ValentinTrinque Mar 5, 2021
52a7471
Add generic table wraper for gherkin
ValentinTrinque Mar 5, 2021
ccd764c
Cleaner and uniform market declaration in feature tests
ValentinTrinque Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions integration/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The `-v` flag tells `go test` to run with verbose output (sending logging to std
To run only certain tests (feature files), you can simply add the paths to a given feature file to the command:

```shell
go test -v ./integration/... -godog.format=pretty $(pwd)/integration/features/simple.feature
go test -v ./integration/... -godog.format=pretty $(pwd)/integration/features/my-feature.feature
```

## Race detection and cache
Expand All @@ -51,7 +51,7 @@ Should there be tests that are intermittently failing, this could indicate a dat
go test -v -count=1 -race ./integration/... -godog.format=pretty

# Same as above, but only run a specific feature file:
go test -v -count=1 -race ./integration/... -godog.format=pretty $(pwd)/integration/feature/core.feature
go test -v -count=1 -race ./integration/... -godog.format=pretty $(pwd)/integration/feature/my-feature.feature
```

Race detection is a complex thing to do, so it will make running tests significantly slower. The pipeline runs the tests with race detection, so this shouldn't be required to do locally.
Expand All @@ -66,6 +66,6 @@ Feature: A feature that reproduces some system test
Background:
Given the insurance pool initial balance for the markets is "0":
And the execution engine have these markets:
| name | baseName | quoteName | asset | markprice | risk model | lamd/long | tau/short | mu | r | sigma | release factor | initial factor | search factor | settlementPrice | openAuction | trading mode | makerFee | infrastructureFee | liquidityFee | p. m. update freq. | p. m. horizons | p. m. probs | p. m. durations | Prob of trading |
| name | base name | quote name | asset | mark price | risk model | lamd/long | tau/short | mu/max move up | r/min move down | sigma | release factor | initial factor | search factor | settlement price | auction duration | trading mode | maker fee | infrastructure fee | liquidity fee | p. m. update freq. | p. m. horizons | p. m. probs | p. m. durations | prob. of trading |
| ETH/DEC20 | ETH | ETH | ETH | 100 | simple | 0.08628781058136630000 | 0.09370922348428490000 | -1 | -1 | -1 | 1.4 | 1.2 | 1.1 | 100 | 1 | continuous | 0.004 | 0.001 | 0.3 | 0 | | | | 0.1 |
```
Loading