Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated feature tests #3101

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Remove outdated feature tests #3101

merged 3 commits into from
Mar 9, 2021

Commits on Mar 9, 2021

  1. Remove outdated feature tests

    @ValentinTrinque
    ValentinTrinque committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    2b054ef View commit details
    Browse the repository at this point in the history

  2. Add generic table wraper for gherkin

    @ValentinTrinque
    ValentinTrinque committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    52a7471 View commit details
    Browse the repository at this point in the history

  3. Cleaner and uniform market declaration in feature tests 

    We were using indexes to iterate through the table, which required to update all the indexes when adding or removing a column.

To ease the maintenance of suche table, we introduce a generic layer to get the column by name, with appropriate type conversion.

This makes us switch from the indexes to column name.

To makes things even clearer, we add a specific layer on top of the generic one and abstract away column names into accessors.

Doing so requires us to uniformize the column name across all tests, which is a good thing.
    @ValentinTrinque
    ValentinTrinque committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ccd764c View commit details
    Browse the repository at this point in the history