Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change location of .vegastrike folder on Windows - master #618

Merged
merged 8 commits into from
Dec 19, 2021
Merged

Change location of .vegastrike folder on Windows - master #618

merged 8 commits into from
Dec 19, 2021

Conversation

stephengtuggy
Copy link
Contributor

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Port Change location of .vegastrike folder on Windows - 0.8.x #615 to master, changing location of .vegastrike and .pu folders on Windows, from "My Documents" to C:\Users\<user>\AppData\Local
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added this to the 0.9.x milestone Dec 7, 2021
@stephengtuggy stephengtuggy requested a review from a team December 7, 2021 21:29
@stephengtuggy stephengtuggy self-assigned this Dec 7, 2021
@stephengtuggy stephengtuggy added this to In progress in 0.9.x Release Dec 19, 2021
Loki1950
Loki1950 approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@Loki1950 Loki1950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @stephengtuggy

@stephengtuggy stephengtuggy merged commit 4cadc1d into vegastrike:master Dec 19, 2021
@stephengtuggy stephengtuggy deleted the win_data_dir_master branch December 19, 2021 21:24
@BenjamenMeyer BenjamenMeyer moved this from In progress to Done in 0.9.x Release Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki1950 Loki1950 Loki1950 approved these changes

@BenjamenMeyer BenjamenMeyer Awaiting requested review from BenjamenMeyer

@ministerofinformation ministerofinformation Awaiting requested review from ministerofinformation

@royfalk royfalk Awaiting requested review from royfalk

Assignees

@stephengtuggy stephengtuggy

Labels
enhancement
Projects
No open projects
0.9.x Release
Done
Milestone
0.9.x
Development

Successfully merging this pull request may close these issues.

Possible alternate locations for .vegastrike subfolder on Windows
2 participants
@stephengtuggy @Loki1950