Change location of .vegastrike folder on Windows - 0.8.x

[stephengtuggy]

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

• Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation
• This is a documentation change only

Issues:

• Please list any related issues
• Implements Possible alternate locations for .vegastrike subfolder on Windows #550 for 0.8.x

Purpose:

• What is this pull request trying to do? Port Fix/CodeQL Warnings 2021-09 (Part 1) #551 to 0.8.x, and then change location of .vegastrike and .pu folders on Windows, from "My Documents" to C:\Users\<user>\AppData\Local
• What release is this for? 0.8.x; 0.9.x pending
• Is there a project or milestone we should apply this to? 0.8.x; 0.9.x pending

[Loki1950]

BTW that is the location that 0.05 placed the config file so there should be #Define with the relevant code still about.

[BenjamenMeyer]

LGTM, but one question: does it preserve the legacy location?

[stephengtuggy]

BTW that is the location that 0.05 placed the config file so there should be #Define with the relevant code still about.

Really? I thought I remembered 0.5.x trying to store all the data under Program Files.

Sure enough, looks like you're right. The My Documents location was introduced by @pheonixstorm in 0d8aadd , in 2012. However, did that make it into 0.5.1r1, the last release from SVN?

[stephengtuggy]

I see that 0.5.1.r1 was released April 1, 2012: https://forums.vega-strike.org/viewtopic.php?f=0&t=18088 . 0d8aadd was committed July 22, 2012. So I don't think that change made it into any of the releases until we switched over to GitHub, at which point VS was no longer playable on Windows anyway.

[stephengtuggy]

The commit before that, 53de752 , dated April 16, 2012, used getenv("USERPROFILE") . And the commit before that is the one with the behavior I remember: 97fb92c , dated October 1, 2003.