[Draft] Implement radar code as a separate component #804
Conversation
closes vegastrike#751 Also add tests and a few additional methods to store.
Add missing return. Other minor fixes.
Introduce the concept of components.
| double random20() | ||
| { | ||
| if(std::rand() < 0.2) { | ||
| return std::rand(); |
There was a problem hiding this comment.
shouldn't this be more like:
double r = std::rand();
if (r < 0.2) {
return r;
}the code you have will retrieve a random number, compare it, and if it's less than 0.2 retrieve another random number to return. not sure that's what was intended.
There was a problem hiding this comment.
I agree with @BenjamenMeyer here.
|
Yes, I like moving things to components. It makes a lot of sense. |
There was a problem hiding this comment.
Nice! I'm excited about this new componentized approach. I think that this is what we've been needing for a long time. I look forward to seeing where it goes.
Some of the refactors I have in mind will also be considerably easier if Unit doesn't inherit from 50 million things LOL
| double random20() | ||
| { | ||
| if(std::rand() < 0.2) { | ||
| return std::rand(); |
There was a problem hiding this comment.
I agree with @BenjamenMeyer here.
| bool can_lock; | ||
| bool tracking_active; | ||
|
|
||
| std::unique_ptr<CRadar> original; |
There was a problem hiding this comment.
Huh! This is interesting. Can you explain this a bit more, Roy? I'm interested to hear what it's for.
| @@ -37,7 +37,7 @@ class Resource { | |||
| T adjusted_max_value_; | |||
| bool no_max_; | |||
| public: | |||
| Resource(const T &value, const T &min_value = 0, const T &max_value = -1); | |||
| Resource(const T &value = 0, const T &min_value = 0, const T &max_value = -1); | |||
There was a problem hiding this comment.
If this constructor can be called with no arguments, or only one argument, it might be best to mark the constructor as explicit.
This PR introduces the concept of components - reactor, radar, cloaking device, etc.
This allows us to more elegantly move code from unit to components.
It will also allow for the removal of unit superclasses (e.g. movable) and easier upgrade, buy, sell, damage and fix components.
Let's use this to PR (and the cloaking one) discuss the concept of using components as a way forward.
Please answer the following:
Code Changes:
Issues:
Purpose: