Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Interval to timelapse setting #59

Closed
MrSerafim opened this issue May 20, 2024 · 7 comments
Closed

Adding Interval to timelapse setting #59

MrSerafim opened this issue May 20, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@MrSerafim
Copy link

Currently, configuring the timelapse feature involves adjusting both FPS and Gain, which the whole gain thing can be confusing, particularly when determining the required gain for a specific interval.

To simplify this process and enhance clarity, I have a suggestion of implementing three fields: FPS, Interval (between shots), and Gain.
Users would input any two of these values, with the third being automatically calculated.

This approach accommodates users who prefer setting the gain directly while also allowing others to specify the interval between shots. By streamlining configuration to just inputting FPS and the time interval between shots, the mod becomes more user-friendly and accessible.

@veger
Copy link
Owner

veger commented May 21, 2024

This sounds interesting, thanks for the idea.

Only challenge is to guess what field should be (re)calculated when the player makes a change... I have this think a little about it. Maybe a 'popup' where 2 values can be filled in, in order to calculate the 3rd when closed? 🤔

@veger veger added the enhancement New feature or request label May 21, 2024
@MrSerafim
Copy link
Author

Thank you for considering my suggestion.

Considering that most users would prefer to keep the set FPS unchanged (i believe), one ideia would be to calculate either the gain or the interval, based which one the user update last.

Another approach is to calculate the oldest value among the three fields based on the order they were filled. This ensures that even when all fields are filled, modifying one would make it the latest filled, that way calculating the new oldest one. However, this may lead to some implications, such as changing the FPS, which could be less intuitive.

@veger
Copy link
Owner

veger commented May 21, 2024

Maybe it makes sense to add a (player) configuration, so the user can chose between interval and gains, depending on their preference? 🤔
The UI then can only show the chosen one and thing should be easy to understand.

As I doubt that both will be used next to each other and I suppose it is more of a personal preference.

@MrSerafim
Copy link
Author

hmm, that does make sense and feels more intuitive.

@veger
Copy link
Owner

veger commented May 23, 2024

Will be available in the next release

@veger
Copy link
Owner

veger commented Oct 21, 2024

Sorry, I totally feogot to release 😞 😞

I have made a v1.5.2 (for Factorio 1) and a v2.0.0 (for Factorio 2), so you can chose which version to use!

@veger veger closed this as completed Oct 21, 2024
@MrSerafim
Copy link
Author

Wow amazing, dont worry about it. Looking foward to test this new feature thanks.
Great work as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants