Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace temporary error with separate error type #587

Open
wenkokke opened this issue Jun 20, 2023 · 1 comment
Open

Replace temporary error with separate error type #587

wenkokke opened this issue Jun 20, 2023 · 1 comment

Comments

@wenkokke
Copy link
Collaborator

wenkokke commented Jun 20, 2023

The following values...

temporaryUnsupportedAlternatingQuantifiers
temporaryUnsupportedNonLinearConstraint

...should be replaced with different constructors without any fields, such as...

  ...
  | BacktrackFromUnsupportedAlternatingQuantifiers
  | BacktrackFromUnsupportedNonLinearConstraint

Perhaps these constructors should even be in a different error type, so that we can statically check if we're always catching them.

@wenkokke wenkokke added enhancement New feature or request refactoring labels Jun 20, 2023
@MatthewDaggitt
Copy link
Collaborator

Yup agreed. It's just difficult to get the monads to align, as we need to throw both the permanent errors and the temporary errors, not to mention we have a lot of helper error functions that assume we're in the permanent error monad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants