Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Additional ANSI Color Choices #30

Closed
drbobbeaty opened this issue Apr 9, 2015 · 2 comments
Closed

Allow Additional ANSI Color Choices #30

drbobbeaty opened this issue Apr 9, 2015 · 2 comments

Comments

@drbobbeaty
Copy link

I'm really impressed by this plugin... very very nice. I went to define the custom color scheme and realized that Ultra only allows the default 8 ANSI colors even though the way their escape codes are being looked up it's possible to add bold- in front of each.

If I might suggest, maybe in colorscheme.clj on line 15, the code might read:

(#{:black :red :green :yellow :blue :magenta :cyan :white
   :bold-black :bold-red :bold-gree :bold-yellow :bold-blue :bold-magenta :bold-cyan :bold-white} k))

so that for those among us that want to have the complete 16 ANSI colors, we can use them.

The other alternative I thought of was to allow the :bold modifier in the vector for a color descriptor. Something like;

  :boolean [:bold :cyan]

In any case, it's a great plugin, and thanks for listening.

@drbobbeaty
Copy link
Author

What a GOOF! It's already there with the second suggestion!

I'm sorry for wasting your time.

@venantius
Copy link
Owner

No worries, glad you're liking it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants