Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-120550 #117

Closed
wants to merge 1 commit into from
Closed

LPS-120550 #117

wants to merge 1 commit into from

Conversation

holatuwol
Copy link

https://issues.liferay.com/browse/LPS-120550

/cc @tototrinh

Background tasks created for 6.2 staging processes do not have an exportImportConfigurationId parameter in the task context map, causing the UI to error out whenever we render them. Proposed fix is to hide the actions that require exportImportConfigurationId.

From @haubuicodeengine:

We will hide 2 options Relaunch and Summary when the exportImportConfigurationId parameter doesn't exist, because it will cause error in init.jsp#L36-L44 and EditPublishConfigurationMVCActionCommand.java#L187

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@holatuwol holatuwol mentioned this pull request Sep 11, 2020
Closed
@vendeltoreki
Copy link
Owner

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9ab5540444c6fe0b87728aef8a05cc986eb65f29

Sender Branch:

Branch Name: LPS-120550
Branch GIT ID: ca8ec31c0c6152b08e4c9d2fef92ec78c5c6ddc0

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4796
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:vendeltoreki#117
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - holatuwol > vendeltoreki - PR#117 - 2020-09-14[01:32:08]
Spira Jenkins Build:publish-spira-report#4558

@vendeltoreki
Copy link
Owner

ci:test:relevant

@vendeltoreki
Copy link
Owner

ci:test:staging

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 54 out of 54 jobs passed in 1 hour 48 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9cf155429b6d1a9e150ed5fcbaf9c1a56e58d7e7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 128d69f3cb43c55e817636ad73b18147091c6836

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 54 out of 54 jobs PASSED
54 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#6628
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:vendeltoreki#117
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - holatuwol > vendeltoreki - PR#117 - 2020-09-14[01:57:48]
Spira Jenkins Build:publish-spira-report#4234

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:staging - 83 out of 85 jobs passed in 2 hours 26 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9cf155429b6d1a9e150ed5fcbaf9c1a56e58d7e7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 128d69f3cb43c55e817636ad73b18147091c6836

ci:test:staging - 83 out of 85 jobs PASSED
83 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#6629
Jenkins Report:jenkins-report.html
Jenkins Suite: staging
Pull Request:vendeltoreki#117
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:staging
Spira Release Build:master - holatuwol > vendeltoreki - PR#117 - 2020-09-14[01:57:58]
Spira Jenkins Build:publish-spira-report#5300

@vendeltoreki
Copy link
Owner

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#94221

@holatuwol holatuwol deleted the LPS-120550 branch October 9, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ci:test:staging - failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holatuwol @liferay-continuous-integration @vendeltoreki @ces-totrinh