Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete Last link in multiple LInks #27

Closed
idleog opened this issue Mar 1, 2023 · 6 comments
Closed

Cannot delete Last link in multiple LInks #27

idleog opened this issue Mar 1, 2023 · 6 comments

Comments

@idleog
Copy link

idleog commented Mar 1, 2023

Describe the bug

In an existing Hyper field with multiple links enabled, I cannot delete the last existing link. After clicking «delete», the link disappears, but after saving the entry, it reappears.

Steps to reproduce

  1. Add a link in a multiple link hyper field
  2. save the entry
  3. delete the link in the hyper field
  4. save the entry

Craft CMS version

4.3.10

Plugin version

1.0.5.2

Multi-site?

Yes

Additional context

No response

@engram-design
Copy link
Member

Can't seem to replicate that I'm afraid. Are you waiting until after the draft has saved (the spinner up near the version-picker dropdown)? It shouldn't matter as it should cancel that event.

Similarly, are you seeing that spinner appear when you delete the link block? That will signify that it's actually doing something, and a change has been detected.

@idleog
Copy link
Author

idleog commented Mar 1, 2023

Hmmm...
When I have 2 links, and I delete one, I see the blue line left of the Linkkfield, marking that something has changed. After saving the blue line disappears, one link has gone. If I delete then the last link, the link disappears, but no blue line is showing. After saving the entry, the link reappears.

before deleting:
Bildschirm­foto 2023-03-01 um 22 22 23

after deleting the link, before saving the entry:
Bildschirm­foto 2023-03-01 um 22 23 57

after saving the entry:
Bildschirm­foto 2023-03-01 um 22 24 16

@engram-design
Copy link
Member

Ah, I see what you mean - yes if it's there's only one link block left that cannot be deleted. Will fix shortly.

@engram-design
Copy link
Member

Fixed for the next release. To get this early run composer require verbb/hyper:"dev-craft-4 as 1.0.5.2"

@idleog
Copy link
Author

idleog commented Mar 2, 2023

Great, works!
Thanks!
Peter

@engram-design
Copy link
Member

Updated in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants