Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Incompetibale and - with fallbacked box-darwing characters #64

Closed
1 of 2 tasks
mwskwong opened this issue Nov 30, 2023 · 3 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Something isn't working

Comments

@mwskwong
Copy link

Font Name (Geist Sans/Geist Mono):

  • Geist Sans
  • Geist Mono

Description of the Issue:
Example usage: ├──, commonly found in the output of tree command.

In this case, Geist Mono doesn't have a character, so it falls back to OS monospace font. Yet, the recent update seems to have changed the style of - and , causing it to misalign with the fallback character

Steps to Reproduce:

  1. Make use of the Geist Mono font and type ├──

Expected Behavior:
├── should be aligned

Screenshots:
image

Environment (please complete the following information):

  • OS: MacOS
  • Software: Edge
  • Version of the Font: 1.1.0

Additional Context:
This issue is not observed in 1.0.1

@mwskwong mwskwong added the bug Something isn't working label Nov 30, 2023
@JohnPhamous
Copy link
Member

Thanks for the bug report. We've fixed in #78. It's available in version 0.2.1.

@mwskwong
Copy link
Author

Screenshot_2024-01-13-10-40-20-631_com android chrome-edit

It still doesn't work too well in Chrome Android. IMO, either provide all commonly used box characters. Or not include any of them in the font. Or else it will always run into compatibility issues with the fallback font.

@JohnPhamous JohnPhamous reopened this Jan 16, 2024
@guidoferreyra guidoferreyra self-assigned this Feb 23, 2024
@souporserious
Copy link

Can confirm this is fixed in 1.3.0, thank you!

image

diegohaz pushed a commit to ariakit/ariakit that referenced this issue Apr 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [geist](https://vercel.com/font)
([source](https://togithub.com/vercel/geist-font/tree/HEAD/packages/next))
| [`1.2.2` ->
`1.3.0`](https://renovatebot.com/diffs/npm/geist/1.2.2/1.3.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/geist/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/geist/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/geist/1.2.2/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/geist/1.2.2/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/geist-font (geist)</summary>

###
[`v1.3.0`](https://togithub.com/vercel/geist-font/releases/tag/1.3.0)

[Compare
Source](https://togithub.com/vercel/geist-font/compare/e3b379199951f3ca99222e704b4972145d42903e...1.3.0)

#### Changelog

-   Improved drawing quality of base letters, numbers, diacritics.
-   Heaviest master x-height raised for better optical compensation.
-   Extended kerning to accented letters.
-   Improved drawing quality of base glyphs
-   Fixed vertical caron design
- Added missing box drawing character
[vercel/geist-font#64
- Set Regular master as default instance
[vercel/geist-font#68
-   Fixed size of ordfemenine and ordmasculine
-   Removed unnecesary full width punctuation
-   Fixed width of small figures
-   Improved set up for auto hinting
-   Fixed Vertical metrics to avoid clipping on Windows
-   Small drawing fixes in other glyphs

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants