Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preferred weight for variable fonts should be 400, not 100. #68

Closed
1 of 2 tasks
chengluyu opened this issue Dec 5, 2023 · 2 comments
Closed
1 of 2 tasks
Labels
bug Something isn't working
Milestone

Comments

@chengluyu
Copy link

Font Name (Geist Sans/Geist Mono):

  • Geist Sans
  • Geist Mono

Description of the Issue:

The preferred weight of Geist Mono Variable is 100, not 400. As a result, most software uses the incorrect default font weight.

Steps to Reproduce:

  1. In "Icons View" of Finder, the weight used for preview is Thin, rather than Regular. (See ❶ in screenshots.)
  2. In "Font Book" App, the weight used for preview is also Thin, but it's displayed as "Regular". (See ❷) If I open the drop-down menu, I will find that Thin is not listed; instead, Regular appears in its place. (See ❸)
  3. After installing the font, if I set the default font in VSCode to Geist Mono Variable without enabling any other options (such as font weight or variable font settings), the default font weight will also be Thin. (See ❹)
  4. When you open a software that allows font setting, such as Text Edit, you won’t find Regular font weight listed in the macOS system font menu either. (See ❺ and ❻)

Expected Behavior:

In the scenarios mentioned above, the default font weight should be 400.

Screenshots:

Here are screenshots mentioned above.

image image image image image image

Environment (please complete the following information):

  • OS: macOS
  • Software: *
  • Version of the Font: 1.1.0

Additional Context:

N/A

@chengluyu chengluyu added the bug Something isn't working label Dec 5, 2023
@chengluyu
Copy link
Author

The fix is very simple. In Glyphs 3’s "Font Info" dialog, we can prioritize the Regular weight by drag it to the top.

Before
image
After
image

I’ve already tried it, and the generated font did not have any of the issues mentioned above.

@chengluyu
Copy link
Author

I’ve created a release with the fix in my own fork. Feel free to give it a try!

@guidoferreyra guidoferreyra added this to the 1.2.0 milestone Feb 1, 2024
diegohaz pushed a commit to ariakit/ariakit that referenced this issue Apr 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [geist](https://vercel.com/font)
([source](https://togithub.com/vercel/geist-font/tree/HEAD/packages/next))
| [`1.2.2` ->
`1.3.0`](https://renovatebot.com/diffs/npm/geist/1.2.2/1.3.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/geist/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/geist/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/geist/1.2.2/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/geist/1.2.2/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/geist-font (geist)</summary>

###
[`v1.3.0`](https://togithub.com/vercel/geist-font/releases/tag/1.3.0)

[Compare
Source](https://togithub.com/vercel/geist-font/compare/e3b379199951f3ca99222e704b4972145d42903e...1.3.0)

#### Changelog

-   Improved drawing quality of base letters, numbers, diacritics.
-   Heaviest master x-height raised for better optical compensation.
-   Extended kerning to accented letters.
-   Improved drawing quality of base glyphs
-   Fixed vertical caron design
- Added missing box drawing character
[vercel/geist-font#64
- Set Regular master as default instance
[vercel/geist-font#68
-   Fixed size of ordfemenine and ordmasculine
-   Removed unnecesary full width punctuation
-   Fixed width of small figures
-   Improved set up for auto hinting
-   Fixed Vertical metrics to avoid clipping on Windows
-   Small drawing fixes in other glyphs

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants