Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure line height #2850

Closed
2 tasks done
Andy-set-studio opened this issue Apr 17, 2018 · 5 comments · Fixed by #2858
Closed
2 tasks done

Configure line height #2850

Andy-set-studio opened this issue Apr 17, 2018 · 5 comments · Fixed by #2858

Comments

@Andy-set-studio
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

Hey Hyper Team,

First of all, the new version looks excellent, so thank you for your ongoing hard work on this 👏

Now that we've got a canvas based rendering system, is it any simpler to increase the line height at all?

Here's two screenshots of Vim, the first using iTerm and the second user Hyper 2.0

iTerm

screen shot 2018-04-17 at 10 49 04

Hyper

screen shot 2018-04-17 at 10 49 41

@msikma
Copy link

msikma commented Apr 17, 2018

As mentioned by @Spaxe in #75, xterm 3.0 exposes a lineHeight option. It doesn't look like it's being passed on, though, since defining it in the config doesn't do anything.

@piotr-yuxuan
Copy link
Contributor

piotr-yuxuan commented Apr 17, 2018

I wonder how such a minor-looking issue (allow to change the height of a line) can still not be resolved after more than one year and a half -- see #75 which still generates quite a lot of activity. What would be the best way for the community to offer help to the maintainers so this long-running issue could be addressed?

@Andy-set-studio
Copy link
Author

#2858 looks like a decent solution. Let's hope this is resolved soon, as I'd love to use Hyper as my primary terminal 🙂

@albinekb
Copy link
Contributor

@piotr-yuxuan because it's not used by a lot of people. Feel free to create a PR. Now we have #2858 so it will be in soon. We're all doing this in our spare time and for free.

@piotr-yuxuan
Copy link
Contributor

Please forgive the tone of my previous message which was too cold. I know we all contribute for free in our spare time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants