-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for opening files. #276
Conversation
Yuss! 👍 |
Yes! |
Hi, great additions, I'm working exactly on the same fix :) There are still a couple of problem to handle:
|
As far as I'm aware |
@kirb, starting from this pull request I've created another pull request (#329) that fixes all the problem we talked about. I wanted to make a pull request to your repo, to merge our PR, but i rebased your code on the last hyperterm master (in order to avoid merge conflicts) and the PR to your repo results in a mess. I hope you're not upset if I create a new PR, I gave you the attribution for your commits and your idea :) |
No worries. It's a group effort after all! |
Closing this in favor of @lordgiotto. Thank you @kirb! |
Nice project! Wanted to contribute a quick little feature.
This implements the
open-file
event onapp
, which is fired when one of the following happens:open -b co.zeit.hyperterm blah.sh
, or equivalent in Cocoa. (This adds support with my own TermHere.)The implementation works like this:
focus
ed (8a4bbd1).open file
command to it; otherwise we create a new window and send it to that (a495b3f).cd
.Bugs – I’m not too sure how these should be fixed:
lastWindow
will be undefined as another window hasn’t gained focus. This also assumes the window manager will give focus to another window from the same app, which I don’t think is the case on Windows.open-file
event.