Fix for #164 – status should not be ignored (#183)

vercel · Mar 14, 2017 · eb7e248 · eb7e248
1 parent 40304d3
commit eb7e248
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/server.js b/lib/server.js
@@ -119,8 +119,10 @@ function send(res, code, obj = null) {
 }
 
 function sendError(req, res, {statusCode, status, message, stack}) {
+  statusCode = statusCode || status
+
   if (statusCode) {
-    send(res, statusCode || status, DEV ? stack : message)
+    send(res, statusCode, DEV ? stack : message)
   } else {
     send(res, 500, DEV ? stack : 'Internal Server Error')
   }

diff --git a/test/index.js b/test/index.js
@@ -6,7 +6,7 @@ const resumer = require('resumer')
 const listen = require('test-listen')
 const micro = require('../lib/server')
 
-const {send, json} = micro
+const {send, sendError, json} = micro
 
 const getUrl = fn => {
   const srv = micro(fn)
@@ -419,3 +419,18 @@ test('limit included in error', async t => {
 
   await getUrl(fn)
 })
+
+test('support for status fallback in errors', async t => {
+  const fn = (req, res) => {
+    const err = new Error('Custom')
+    err.status = 403
+    sendError(req, res, err)
+  }
+
+  const url = await getUrl(fn)
+  try {
+    await request(url)
+  } catch (err) {
+    t.deepEqual(err.statusCode, 403)
+  }
+})