Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String with implicit unit return undefined #110

Closed
1000i100 opened this issue Sep 29, 2018 · 4 comments
Closed

String with implicit unit return undefined #110

1000i100 opened this issue Sep 29, 2018 · 4 comments

Comments

@1000i100
Copy link

It's near the same than : #54
but for string like this : 9h30, 1m15

@1000i100
Copy link
Author

Finally, I handle it this way : https://framagit.org/1000i100/rml12/-/blob/master/yml2ics.js#L11

@1000i100
Copy link
Author

1000i100 commented Dec 7, 2020

why closing this without any word ?

There is good reason to do it and there is good reason to not do it :

  • KISS (Keep It Stupid Simple) can explain not doing it
  • normalize what human use, even if it's weird can explain doing it.

Please, explain your vision about ms, it will help to contribute by pull-request or by other project with ms as dependency. It depend of your vision for ms.

@1000i100
Copy link
Author

1000i100 commented Dec 7, 2020

Ok, from #138 and #55
I understand you're ok to merge something like this if there is a merge-request/pull-request, rebased to be up-to-date and with unit test to cover the new stuff.

If yes, i should begin with a pull-request to add a CONTRIBUTE guide-line you can link to quick explain why you close or not this kind of issue.

@styfle
Copy link
Member

styfle commented Dec 7, 2020

I closed because you said it was handled and you linked to the duplicate #54

I'll discuss with the team to decide the future of ms but for now it is mostly complete, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants